🐛 fix version check when reading webhooks from file

[databus23]

At the moment the DirectoryPaths option of the WebhookInstallOptions is broken. This PR fixes it.

Fixed #867

[k8s-ci-robot]

Welcome @databus23!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @databus23. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/ok-to-test

Can we add or adjust existing unit tests?

[databus23]

@vincepri Here you go

[vincepri]

/approve
/assign @DirectXMan12 @alenkacz
for final lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: databus23, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alenkacz]

Few smaller issues, then it will be ready to go.

Thanks for fixing this!

[databus23]

@alenkacz Thanks for the feedback. All done.

[alenkacz]

/lgtm

thanks for the fix

[DirectXMan12]

We should follow up later with more specific robust tests that clearly highlight what's supported an what's not. These are fine for now, but we should have ones that test the negative cases, and specifically test what we care about ("v1 works", "v1beta1 works", etc).

[databus23]

@alenkacz Now that this is merged in master can we include this in a 0.5.x release as a bugfix?