-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add controllerutil.EnsureOwnerReference #816
✨ Add controllerutil.EnsureOwnerReference #816
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8fc450e
to
710a875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a good change. Gave my best shot at meaningful feedback 😎. Nice work.
710a875
to
01c5f95
Compare
/test pull-controller-runtime-test-master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny nits, other than that lgtm
01c5f95
to
8a0251a
Compare
Signed-off-by: Vince Prignano <[email protected]>
8a0251a
to
05bc80c
Compare
/lgtm |
Signed-off-by: Vince Prignano [email protected]
/assign @alvaroaleman