✨ Default QPS to a saner value in and out of tests #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
droot
added
the
lgtm
|
/lgtm |
|
It seems |
If you share client across a test, then client-side rate-limitting will slow down your test drastically.
This defaults the loaded REST Config QPS to 20 (burst 30), which matches what the kube controller manager has. The defaults of 5 and 10 (respectively) are pretty slow, especially since they're shared across multiple controllers.
DirectXMan12
force-pushed
the
bug/sane-qps
branch
from
ddf6abf to
a82afb4
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
updated vendor deps to use versioned deps of controller-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default QPS on REST clients is 5 (with burst to 10), which is rather slow. This is especially true when running a test server, since you want to run tests pretty quickly, and the test cluster is default.
For normal clients, we probably want to default to what the KCM defaults to (our situation isn't quite the same, since we actually share the client across controllers, so we should follow up dealing with that at some point). This gives us 20 QPS with burst to 30.