-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ admission.Decoder is now an interface #2736
Conversation
The current implementation allows to create a decoder without a scheme/codecs by just referencing the struct `&admission.Decoder{}` given that codecs is private. The field was filled in before with the inject package which has been removed. This change retains the Decoder definition and makes it an interface, `admission.NewDecoder(scheme)` is now the only way to instantiate our default decoder. Signed-off-by: Vince Prignano <[email protected]>
d557775
to
04c37a9
Compare
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The controller-manager won't automatically inject decoder to webhook handler in new implementation, which will cause the panic error of webhook. Use admission.NewDecoder(scheme) instead as it is now the only way to instantiate default decoder. kubernetes-sigs/controller-runtime#2736
#126) * chore(deps): bump sigs.k8s.io/controller-runtime from 0.17.3 to 0.18.4 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.17.3 to 0.18.4. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.4) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: admission.Decoder is an interface now kubernetes-sigs/controller-runtime#2736 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martin Ohmann <[email protected]>
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <[email protected]>
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <[email protected]>
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <[email protected]>
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <[email protected]>
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <[email protected]>
The current implementation allows to create a decoder without a scheme/codecs by just referencing the struct
&admission.Decoder{}
given that codecs is private. The field was filled in before with the inject package which has been removed. This change retains the Decoder definition and makes it an interface,admission.NewDecoder(scheme)
is now the only way to instantiate our default decoder.Fixes #2695