⚠ Bump k8s.io/ to v1.30.0-beta.0

[twz123]

Kubernetes 1.30 has a breaking API change around leader election metrics, introduced in kubernetes/kubernetes#122069. Not sure if there's a trick to fixing this in a way that's compatible with both 1.29 and 1.30 at the same time. Not sure when controller-runtime wants to jump to k8s 1.30, so leaving this as a draft.

[k8s-ci-robot]

Welcome @twz123!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @twz123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

@twz123 Do you have time to rebase to v1.30.0-beta.0? In general I would bump to v1.30 now for early feedback.

I'm not sure I understand what the breaking change around leader election metrics is

EDIT: Ah that they renamed & changed the SwitchMetric/LeaderMetric interface? I don't think we can mitigate that. The problem is that we can't add an additional method which returns leaderelection.SwitchMetric, because this interface doesn't exist anymore in the client-go version we import

[sbueringer]

/ok-to-test

[sbueringer]

/retest

[twz123]

Is there some way to let Prow use Go 1.22? Kubernetes 1.30 requires it.

[sbueringer]

Is there some way to let Prow use Go 1.22? Kubernetes 1.30 requires it.

Yes, you have to bump the images in:

• https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-presubmits-main.yaml
• https://github.com/kubernetes/test-infra/blob/4b5df3616d2497721034b8505c6e8a2365862c4d/config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-periodics-main.yaml

Can you open a PR for that? (then I can approve)

[sbueringer]

Do you know what the exact implications are of using go 1.22.0 and toolchain go1.22.1?

(specifically the exact patch version in each)

[twz123]

According to https://go.dev/doc/toolchain#config, IIUC, the go directive specifies the minimum required version, while the toolchain directive specifies the suggested version. Perhaps the toolchain directive could be removed altogether here?

[sbueringer]

Maybe. Is it automatically added by go mod tidy?

[twz123]

I've seen this added automatically sometimes, but I haven't caught the pattern yet. It definitely won't be added by go mod tidy if everything is in sync, at least not for me.

[sbueringer]

Did a bit of reserach:

• if go and toolchain use the same version, go mod tidy will remove toolchain (i.e. it's only preserved if the versions are different)
• we introduced toolchain when bumping to Go 1.21. I believe either this was added because we used 1.21 (instead of 1.21.0) for the go directive or because the cleanup in go mod tidy wasn't implemented yet.

Kubernetes today only sets the Go directive to 1.22.0 and omits the toolchain directive: https://github.com/kubernetes/kubernetes/blob/master/go.mod#L9

I would like to follow this pattern for now, if we don't have a good reason to set the toolchain directive as well.

[sbueringer]

Here is more context on the whole topic: https://go.dev/doc/toolchain

My tl;dr for here is basically I don't think we need a different minimum and preferred toolchain

[sbueringer]

This one is interesting

Commands that incorporate new module versions that require new Go versions write the new minimum go version requirement to the current workspace’s go.work file or the main module’s go.mod file, updating the go line. For repeatability, any command that updates the go line also updates the toolchain line to record its own toolchain name. The next time the go command runs in that workspace or module, it will use that updated toolchain line during toolchain selection.

[twz123]

There you go:

• Bump go version to 1.22 for controller-runtime kubernetes/test-infra#32265

[sbueringer]

/retest

[pmalek]

Can we have this in release-0.17 to prevent

Error: ../../../go/pkg/mod/sigs.k8s.io/[email protected]/pkg/metrics/leaderelection.go:26:71: undefined: leaderelection.SwitchMetric

with recent k8s 1.30 packages?

[sbueringer]

No because this would make CR v0.17.x incompatible with client-go v0.29

[pmalek]

ACK. When do we expect to ship 0.18?

[sbueringer]

Current plan is ~ this week. Can't guarantee it though.

Mostly depends on #2783 as far as I can tell