Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add missing return statement in the webhook admissions func #2433

Merged
merged 1 commit into from
Aug 16, 2023
Merged

🐛 Add missing return statement in the webhook admissions func #2433

merged 1 commit into from
Aug 16, 2023

Conversation

lleshchi
Copy link
Contributor

@lleshchi lleshchi commented Aug 3, 2023

Closes: #2429

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lleshchi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
@FillZpp
Copy link
Contributor

FillZpp commented Aug 3, 2023

/ok-to-test

Please add an unit test for this.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2023
@sbueringer sbueringer added this to the v0.16.x milestone Aug 4, 2023
@sbueringer
Copy link
Member

@lleshchi Do you have some time to add a test for the underlying bug?
Would be nice to get this into the upcoming v0.16 release that we want to cut soon'ish :)

@lleshchi
Copy link
Contributor Author

@sbueringer yes, will add one in today

@lleshchi
Add missing return statement in the webhook admissions func
f965032 
As the function is currently written without a return, for an
unstructured object which is successfully unmashalled, it will fall
through to the subsequent lines and fail to decode properly.

Add return statement to successful unstructured decode.

Signed-off-by: Leah Leshchinsky <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@vincepri
Copy link
Member

/retest

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lleshchi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6d99b58 into kubernetes-sigs:main Aug 16, 2023
@psalaberria002
Copy link

Would it be possible to release this in 0.15.2? If not, when is 0.16 expected to be out?

@sbueringer
Copy link
Member

sbueringer commented Aug 18, 2023 •
edited
Loading

Would it be possible to release this in 0.15.2? If not, when is 0.16 expected to be out?

I can't promise a specific date for v0.16, but I assume we're talking about a few days

@sbueringer
Copy link
Member

I'll cherry-pick independent of that

/cherry-pick release-0.15

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 18, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #2452

In response to this:

I'll cherry-pick independent of that

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.16.x
Development

Successfully merging this pull request may close these issues.

Missing return statement in the webhook admissions func (*Decoder).DecodeRaw
8 participants
@lleshchi @k8s-ci-robot @FillZpp @sbueringer @vincepri @psalaberria002 @k8s-infra-cherrypick-robot @alvaroaleman