-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱fix default value for cfg.Burst #2142
Conversation
Signed-off-by: yanggang <[email protected]>
Welcome @yanggangtony! |
Hi @yanggangtony. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Seems reasonable to me. client-go also has separate defaults (even though different ones than the ones we have) |
What/Where are the default client-go values that you were looking at? |
I was looking here: https://github.com/kubernetes/client-go/blob/master/rest/config.go#L43-L46 (and then the independent defaulting e.g. in RESTClientForConfigAndClient) But it's probably too much to actually call them "client go defaults". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri, yanggangtony The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yanggang [email protected]
fix config default value.
when the cfg.Burst!=0 , can not change it value.