🐛 Fix panic for lazy dynamicRESTMapper #1891
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
@FillZpp: GitHub didn't allow me to request PR reviews from the following users: siliconbrain. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| var failedOnce bool | ||
| mockErr := fmt.Errorf("mock failed once") | ||
| mapper, err = NewDynamicRESTMapper(cfg, WithLazyDiscovery, WithCustomMapper(func() (meta.RESTMapper, error) { | ||
| // Make newMapper failed once |
There was a problem hiding this comment.
| // Make newMapper failed once | |
| // Make newMapper fail once |
|
@siliconbrain: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: FillZpp <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, FillZpp, siliconbrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
/retest-required |
Signed-off-by: FillZpp [email protected]
Fix panic for lazy dynamicRESTMapper to make
setStaticMappersuccessfully once, which means if dynamicRESTMapper fails tosetStaticMapper, it will do it once again in nextinit.fixes #1712