✨ Improve the fake client builder with WithObjectTracker option

[Waynegates]

This pr improves the fake client with WithObjectTracker option.
This is useful when users want to set up unit tests across different fake client.
For example, when users are testing with client-go and kubebuilder, users will create a fake clientSet and a fake client.
Users can get the object tracker from the fake clientSet and set it to the fake controller-runtime client by this new option to let them share the same fake resources.
This will allow users to write more unit tests.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Waynegates (96d4d6c, ca968c6, b093def, 0c5e73a)

[k8s-ci-robot]

Welcome @Waynegates!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Waynegates. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Waynegates]

/assign @mengqiy

[Waynegates]

Reference to a related issue. #1458

[sriram-anyscale]

Thanks for doing this. Looks good.

[alvaroaleman]

@Waynegates thanks for your contribution. In order for us to be able to accept it, you need to sign the CLA as pointed out by the bot: #1863 (comment)

/cc @sbueringer
WDYT? Approach seems good to me

Also, please add tests for this.

[Waynegates]

Thanks. I will ask for CLA and add tests. Best wishes! ------------------------------------------------------------------- Bruce Zhang Uber Technology, CA, US Alvaro Aleman ***@***.***> 于2022年4月14日周四 13:38写道：

…

@Waynegates <https://github.com/Waynegates> thanks for your contribution. In order for us to be able to accept it, you need to sign the CLA as pointed out by the bot: #1863 (comment) <#1863 (comment)> /cc @sbueringer <https://github.com/sbueringer> WDYT? Approach seems good to me Also, please add tests for this. — Reply to this email directly, view it on GitHub <#1863 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABN5D7ERCAPQGEHKKT2QWL3VFB63NANCNFSM5TB65BOQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Waynegates]

@Waynegates thanks for your contribution. In order for us to be able to accept it, you need to sign the CLA as pointed out by the bot: #1863 (comment)

/cc @sbueringer WDYT? Approach seems good to me

Also, please add tests for this.

I have added the unit test. And I have requested to create a EasyCLA manager for my company Anyscale to let me pass the CLA Authorization.
Thanks.

[Waynegates]

@alvaroaleman @mengqiy @pwittrock @vincepri @sbueringer
I have got EasyCLA approved, added unit tests and check my PR.
Could any of you help to review the PR? Thanks!

[alvaroaleman]

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, Waynegates

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/cc @sbueringer WDYT? Approach seems good to me

Back from PTO, looks good to me too. (and solves my issue #1458)