Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions in testutil are commented out #386

Closed
bogdanpetrea opened this issue Apr 5, 2019 · 6 comments · Fixed by #814
Closed

Functions in testutil are commented out #386

bogdanpetrea opened this issue Apr 5, 2019 · 6 comments · Fixed by #814
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@bogdanpetrea
Copy link

I would like to disable the client caching in some of my tests as it doesn't always seem to reflect the latest resource changes and it really gets in the way.

If I use a new client I can see the latest changes as expected so I assume it's a caching thing. But If I use a different client from the one that the test manager uses, they will always be unsynced, so it's still a caching problem.

It seemed like these functions might help me in disabling the cache, although I'm not sure it's possible. Any clue why they are commented?

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Apr 5, 2019

I'm not even sure why they're still there -- they should be removed.

For tests, the recommendation is just to do
"sigs.k8s.io/controller-runtime/pkg/client".New(...) for use in the actual test methods (which will get you a non-caching client). Would that solve your issue, or are you trying to have your actual controllers use a non-caching client?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2019
@DirectXMan12
Copy link
Contributor

/remove-lifecycle rotten
/lifecycle frozen

we should remove that file

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 6, 2019
@vincepri
Copy link
Member

/help
/good-first-issue
/priority backlog

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue
/priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 20, 2020
@vincepri vincepri added this to the v0.5.x milestone Feb 20, 2020
prateekpandey14 added a commit to prateekpandey14/controller-runtime that referenced this issue Feb 24, 2020
commits remove the testutil.go file which
is  commented and no longer required.

fixes:kubernetes-sigs#386

Signed-off-by: prateekpandey14 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants