Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add move annotation on objects for cluster move operation #8322

Merged
merged 1 commit into from
Apr 14, 2023
Merged

🌱 Add move annotation on objects for cluster move operation #8322

merged 1 commit into from
Apr 14, 2023

Conversation

pkbhowmick
Copy link
Contributor

@pkbhowmick pkbhowmick commented Mar 21, 2023 •
edited
Loading

What this PR does / why we need it:
Add move annotation on objects those are going to be deleted for cluster move operation.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8109

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @pkbhowmick!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pkbhowmick. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pkbhowmick pkbhowmick changed the title Add move annotation on objects for cluster move operation 🌱 Add move annotation on objects for cluster move operation Mar 21, 2023
@ykakarap
Copy link
Contributor

@pkbhowmick Thanks for opening the PR. I will take a look at this tomorrow.

@killianmuldoon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/clusterctl Issues or PRs related to clusterctl size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2023
@fabriziopandini
Copy link
Member

/test pull-cluster-api-e2e-full-main

@pkbhowmick pkbhowmick force-pushed the add-patch-annotation branch 2 times, most recently from 82dbf03 to 9163716 Compare March 29, 2023 14:41
@pkbhowmick
Copy link
Contributor Author

Hi @fabriziopandini
Tests passed & squashed the commit. PTAL!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2023
@pkbhowmick
Copy link
Contributor Author

@fabriziopandini
updated the migration doc & rebase the PR as well.

@pkbhowmick
Copy link
Contributor Author

/retest

@fabriziopandini fabriziopandini mentioned this pull request Apr 5, 2023
Closed
@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 5, 2023
Closed
3 tasks
ykakarap
ykakarap reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

LGTM otherwise.

cmd/clusterctl/client/cluster/mover.go Outdated Show resolved Hide resolved
@pkbhowmick pkbhowmick force-pushed the add-patch-annotation branch from 88347e3 to 461079f Compare April 5, 2023 18:25
@pkbhowmick
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2023 •
edited
Loading

@pkbhowmick: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-full-main 6fcf0e2 link false /test pull-cluster-api-e2e-full-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pkbhowmick pkbhowmick force-pushed the add-patch-annotation branch from 461079f to de84cd7 Compare April 5, 2023 18:56
@pkbhowmick
Copy link
Contributor Author

/retest

@pkbhowmick pkbhowmick requested a review from ykakarap April 6, 2023 06:35
@fabriziopandini
Copy link
Member

fabriziopandini commented Apr 14, 2023 •
edited
Loading

we are near the finish line, one last rebase (it will probably fix markdown links too)...

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
@pkbhowmick pkbhowmick force-pushed the add-patch-annotation branch from de84cd7 to a044e4a Compare April 14, 2023 15:19
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
@pkbhowmick pkbhowmick force-pushed the add-patch-annotation branch from a044e4a to 4ac5f3d Compare April 14, 2023 15:21
@pkbhowmick
Copy link
Contributor Author

we are near the finish line, one last rebase (it will probably fix markdown links too)...

Yes, rebase done!

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a82ff8af88d3e8d2f007469d5974a3c935680a7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit e774ad5 into kubernetes-sigs:main Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 14, 2023
@pkbhowmick pkbhowmick mentioned this pull request Apr 14, 2023
Merged
3 tasks
@christianang christianang mentioned this pull request May 9, 2023
Closed
@killianmuldoon killianmuldoon mentioned this pull request May 18, 2023
Merged
@nawazkh nawazkh mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

API Object is being deleted for clusterctl move should have an annotation to identify move operation
5 participants
@pkbhowmick @k8s-ci-robot @ykakarap @killianmuldoon @fabriziopandini