Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Managed Cluster should set labels and annotations on ControlPlane and MDs #7917

Merged
merged 1 commit into from
Jan 20, 2023
Merged

✨ Managed Cluster should set labels and annotations on ControlPlane and MDs #7917

merged 1 commit into from
Jan 20, 2023

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Jan 13, 2023 •
edited
Loading

What this PR does / why we need it:

This PR adds support to apply labels and annotations to the ControlPlane and MachineDeployment objects.

Credit to @MaxFedotov for doing the initial implementation.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #7731
Related issue: #7006

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2023
@ykakarap ykakarap mentioned this pull request Jan 13, 2023
Closed
@ykakarap
Copy link
Contributor Author

/retest

@ykakarap ykakarap force-pushed the label-propagation_clusters-to-objects branch 2 times, most recently from ce5fd91 to bb415a2 Compare January 17, 2023 23:19
@ykakarap ykakarap changed the title ✨ [WIP] Managed Cluster should set labels and annotations on ControlPlane and MDs ✨ Managed Cluster should set labels and annotations on ControlPlane and MDs Jan 17, 2023
@ykakarap
Copy link
Contributor Author

/cc @fabriziopandini @sbueringer

sbueringer
sbueringer reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! overall lgtm just a few nits

api/v1beta1/cluster_types.go Show resolved Hide resolved
internal/controllers/topology/cluster/desired_state.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/desired_state.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/desired_state.go Outdated Show resolved Hide resolved
@ykakarap ykakarap force-pushed the label-propagation_clusters-to-objects branch from bb415a2 to 135d4fc Compare January 18, 2023 19:35
@sbueringer
Copy link
Member

Code looks good. Let's run the full tests
/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

Code looks good. Let's run the full tests
/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 970bc40a9556236bd850a914417d52c54a8eb86f

@ykakarap ykakarap mentioned this pull request Jan 19, 2023
Closed
19 tasks
@fabriziopandini
Copy link
Member

Thanks, @MaxFedotov and @ykakarap.
That's a great start for the work on labels and annotations!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 41f7dda into kubernetes-sigs:main Jan 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 20, 2023
@fabriziopandini fabriziopandini mentioned this pull request Feb 2, 2023
Closed
@mnaser mnaser mentioned this pull request Jul 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ykakarap @sbueringer @k8s-ci-robot @fabriziopandini