🌱 Use the Go SDK context package consistently #7426
Conversation
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
@fabriziopandini Doesn't help to get rid of the dependency, but might still be a useful cleanup. |
k8s-ci-robot
added
the
lgtm
|
Related #7427 |
| "fmt" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
| "golang.org/x/net/context" |
There was a problem hiding this comment.
just out of curiosity, what was the reason to use context from this package?
There was a problem hiding this comment.
I can only guess, and I would guess IDE auto-completion picked the wrong one.
The Context from this package is actually just an alias to the one from the SDK
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Ensures we use the Go SDK context package consistently.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #