Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Use new registry in published manifests #7410

Merged
merged 1 commit into from
Nov 2, 2022
Merged

🌱 Use new registry in published manifests #7410

merged 1 commit into from
Nov 2, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Oct 14, 2022

What this PR does / why we need it:

This pr replaces all k8s.gcr.io with registry.k8s.io. I remember trying this a while back and running into issues due to some images not being available. But now it seems to work for the none malformed image registries.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7402

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2022
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2022
@oscr
Copy link
Contributor Author

oscr commented Oct 14, 2022

/test all

@sbueringer sbueringer marked this pull request as ready for review October 15, 2022 05:35
@oscr oscr changed the title [WIP]🌱 Change registry from k8s.gcr.io to registry.k8s.io 🌱 Change registry from k8s.gcr.io to registry.k8s.io Oct 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2022
@fabriziopandini
Copy link
Member

This needs some time for review, I will try to make a first pass before KubeCon

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 18, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
sbueringer
sbueringer reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr there are a few places where we have to keep the old registry.

We will only migrate from the old to the new registry after certain Kubernetes releases, which is why we can't just replace all occurences of the old registry with the new one

Basically the only behavioral change we want is the one in the Makefile (some of the changes like unit / e2e tests / doc are fine though)

bootstrap/kubeadm/types/upstreamv1beta1/types.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_coredns.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_coredns_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_test.go Outdated Show resolved Hide resolved
docs/book/src/developer/providers/v1.2-to-v1.3.md Outdated Show resolved Hide resolved
test/framework/kubernetesversions/data/debian_injection_script.envsubst.sh.tpl Outdated Show resolved Hide resolved
test/framework/daemonset_helpers.go Outdated Show resolved Hide resolved
test/framework/deployment_helpers.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2022
@sbueringer
Copy link
Member

Thank you very much!!
(especially for the quick follow-up after the review)

/lgtm
/approve

Trying this out with the beta release today

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 91b88ee into kubernetes-sigs:main Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Nov 2, 2022
@sbueringer sbueringer mentioned this pull request Nov 2, 2022
Merged
@sbueringer
Copy link
Member

/retitle 🌱 Use new registry in published manifests

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Change registry from k8s.gcr.io to registry.k8s.io 🌱 Use new registry in published manifests Nov 2, 2022
@oscr
Copy link
Contributor Author

oscr commented Nov 2, 2022

@sbueringer Thank you for your great help and encouragement 🙏

@sbueringer
Copy link
Member

You're welcome :). Thx for working on this issue :)

@furkatgofurov7 furkatgofurov7 mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@sbueringer sbueringer sbueringer left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Change registry in published manifests to registry.k8s.io
5 participants
@oscr @k8s-ci-robot @fabriziopandini @sbueringer @ameukam