Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 clusterctl: adjust Overrider interface so Path can return an error #7369

Merged
merged 1 commit into from
Oct 12, 2022
Merged

🌱 clusterctl: adjust Overrider interface so Path can return an error #7369

merged 1 commit into from
Oct 12, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 7, 2022 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Follow-up to #7343

We didn't change this in #7343 because we wanted to cherry-pick #7343 into release-1.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2022
@sbueringer sbueringer changed the title clusterctl: adjust Overrider interface so Path can return an error 🌱 clusterctl: adjust Overrider interface so Path can return an error Oct 7, 2022
@sbueringer
Copy link
Member Author

cc @fabriziopandini @ykakarap (no rush)

@sbueringer
Copy link
Member Author

Let's merge + cherry-pick #7375 first

@sbueringer
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2022
fabriziopandini
fabriziopandini reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit, otherwise lgtm for me

cmd/clusterctl/client/repository/overrides.go Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-clusterctl-adjust-overrider-interface branch from 9fd17c8 to 9e74062 Compare October 10, 2022 14:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2022
@sbueringer
Copy link
Member Author

@fabriziopandini Rebased + added to the migration doc

@sbueringer sbueringer force-pushed the pr-clusterctl-adjust-overrider-interface branch from 9e74062 to a21abfe Compare October 10, 2022 14:52
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main a21abfe link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@fabriziopandini
Copy link
Member

Nice change!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0ef534e into kubernetes-sigs:main Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Oct 12, 2022
@sbueringer sbueringer deleted the pr-clusterctl-adjust-overrider-interface branch October 13, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @fabriziopandini