Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 In place propagation of changes affecting Kubernetes objects only #7331

Merged
merged 3 commits into from
Dec 2, 2022
Merged

📖 In place propagation of changes affecting Kubernetes objects only #7331

merged 3 commits into from
Dec 2, 2022

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This Proposal takes over from the work in #6255 and focuses on

  • Define how labels propagate from ClusterClass to KCP/MachineDeployments/Machine Pools and down to Machines
  • Define how to prevent labels propagation triggers unnecessary rollouts

This proposal is complementary to #7296

Which issue(s) this PR fixes:
Fixes #493

cc @Arvinderpal @enxebre @sbueringer @vincepri

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2022
@fabriziopandini fabriziopandini changed the title 📖 In place propagation of changes affecting Kubernetes objects only [WIP] 📖 In place propagation of changes affecting Kubernetes objects only Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
sbueringer
sbueringer reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall sounds good.

I just opened a PR against your branch for the nits. To save us both some work and avoid noise on this PR: fabriziopandini#27 (hope that's okay)

docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the kubernetes-objects-only-change-propagation branch from e4b5ad2 to 461ce4d Compare October 7, 2022 20:04
@fabriziopandini fabriziopandini changed the title [WIP] 📖 In place propagation of changes affecting Kubernetes objects only 📖 In place propagation of changes affecting Kubernetes objects only Oct 19, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@fabriziopandini fabriziopandini force-pushed the kubernetes-objects-only-change-propagation branch from a1aa71d to ff2f34b Compare October 19, 2022 13:51
@sbueringer sbueringer mentioned this pull request Nov 3, 2022
Closed
g-gaston
g-gaston reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense, lgtm

docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Nov 16, 2022
Closed
sbueringer
sbueringer reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits.

Great work!

I especially like the diagrams!!

P.S. As mentioend above, rebase should solve the linkchecker issue.

docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Outdated Show resolved Hide resolved
docs/proposals/20221003-In-place-propagation-of-Kubernetes-objects-only-changes.md Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the kubernetes-objects-only-change-propagation branch from ff2f34b to 76520bd Compare November 23, 2022 12:16
@fabriziopandini
Copy link
Member Author

rebased + fixed all the nits

@sbueringer
Copy link
Member

I think you missed the two findings from Guillermo (#7331 (comment), #7331 (comment)). Apart from those, lgtm from my side

@fabriziopandini
Copy link
Member Author

Sorry for missing Guillermo feedback in the first pass, now it should be fixed

@g-gaston
Copy link
Contributor

g-gaston commented Nov 28, 2022 •
edited
Loading

/lgtm

@sbueringer
Copy link
Member

Thank you very much!!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2022
vincepri
vincepri approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8799883 into kubernetes-sigs:main Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Dec 2, 2022
@fabriziopandini fabriziopandini deleted the kubernetes-objects-only-change-propagation branch December 15, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston g-gaston left review comments

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis jackfrancis left review comments

@enxebre enxebre enxebre left review comments

@vincepri vincepri vincepri approved these changes

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Support syncing a set of labels from MachineDeployment/MachineSet/Machine to Nodes
7 participants
@fabriziopandini @sbueringer @g-gaston @k8s-ci-robot @enxebre @jackfrancis @vincepri