Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 clarify backport-policy #7167

Merged
merged 1 commit into from
Sep 26, 2022
Merged

📖 clarify backport-policy #7167

merged 1 commit into from
Sep 26, 2022

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
As per office hours discussing clarifying backport policy for doc improvements, CI signal improvements, test framework improvements

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2022
sbueringer
sbueringer reviewed Sep 5, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
furkatgofurov7
furkatgofurov7 reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm as well

CONTRIBUTING.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@sbueringer
Copy link
Member

/lgtm

I'll bring the topic up in the office hours today as well

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
ykakarap
ykakarap reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@fabriziopandini
Copy link
Member Author

Added a note for backporting changes required to support new Kubernetes versions, if possible

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@furkatgofurov7 furkatgofurov7 mentioned this pull request Sep 9, 2022
Merged
killianmuldoon
killianmuldoon approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member Author

@CecileRobertMichon @enxebre @vincepri kindly ping

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve
/hold

Hold to give @enxebre @vincepri a chance to review. Feel free to unhold when ready to merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@fabriziopandini
Copy link
Member Author

/hold cancel

we got +1 from Vince and we are basically documenting what we are already doing since some time now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9907d10 into kubernetes-sigs:main Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 26, 2022
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #7289

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 26, 2022
Merged
@fabriziopandini fabriziopandini deleted the clarify-backport-policy branch October 10, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@ykakarap ykakarap ykakarap left review comments

@sbueringer sbueringer sbueringer left review comments

@randomvariable randomvariable randomvariable left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
10 participants
@fabriziopandini @sbueringer @CecileRobertMichon @k8s-ci-robot @k8s-infra-cherrypick-robot @randomvariable @vincepri @ykakarap @furkatgofurov7 @killianmuldoon