Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 book: add support dates #6271

Merged
merged 1 commit into from
Mar 8, 2022
Merged

📖 book: add support dates #6271

merged 1 commit into from
Mar 8, 2022

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Just syncing the dates from main to release-1.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2022
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot requested review from enxebre and vincepri March 8, 2022 15:54
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2022
killianmuldoon
killianmuldoon approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@sbueringer
Copy link
Member Author

Had to fix the old book too

@sbueringer sbueringer force-pushed the pr-support-dates branch 2 times, most recently from 97bfe92 to affef5b Compare March 8, 2022 17:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
@sbueringer sbueringer force-pushed the pr-support-dates branch 3 times, most recently from 9a98fc7 to 416478c Compare March 8, 2022 17:38
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2022
@killianmuldoon
Copy link
Contributor

I guess we should try to backport link updates to books for supported versions in future? Otherwise we'll always get these broken links when trying to make unrelated changes.

@sbueringer
book: add support deadlines
affc1d9 
Signed-off-by: Stefan Büringer [email protected]
sbueringer
sbueringer commented Mar 8, 2022
View reviewed changes
.gitignore
@@ -61,6 +61,8 @@ vendor
# User-supplied Tiltfile extensions, settings, and builds
tilt.d
tilt-settings.json
tilt-settings.yaml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure nobody accidentally commits too much :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. yes I rotated my AWS credentials :)

@sbueringer
Copy link
Member Author

I guess we should try to backport link updates to books for supported versions in future? Otherwise we'll always get these broken links when trying to make unrelated changes.

If these are fixes which also apply to previous versions - yes.

fabriziopandini
fabriziopandini reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 31146bd into kubernetes-sigs:release-1.1 Mar 8, 2022
@sbueringer sbueringer deleted the pr-support-dates branch March 8, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @killianmuldoon @k8s-ci-robot @fabriziopandini