-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow ApplyAlways mode for ClusterResourceSets #6188
Conversation
Hi @alejandroEsc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this directly address #4807 ? @alejandroEsc |
Yes it does. |
Discussed this in the Feb 23 2022 office hours. A recap: ClusterResourceSet is experimental, and updating its functionality is part of its experimental nature. The project offers no API guarantees; CRS can be deprecated at any time. However, because there may be enough time to implement a longer-term alternative to ClusterResourceSet before the next minor release, some maintiners would like additional time to consider the alternative, before merging this PR. |
/hold Until further discussions on the addons RFE #5491 and related proposals |
@vincepri I'm confused. We had discussed your desire to block this and there didn't seem to be any community consensus to do so. I don't see any reason to not let this move forward because CRS is experimental and changes to it have no bearing on the outcome of #5491. @g-gaston Do you want to add anything? This affects your project as well, as I understand it. |
closing as we are not considering this anymore |
What this PR does / why we need it: This allows an ApplyAlways mode that will apply updated resource sets to all bound clusters whenever a change is recognized.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #