Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow ApplyAlways mode for ClusterResourceSets #6188

Closed

Conversation

alejandroEsc
Copy link
Contributor

What this PR does / why we need it: This allows an ApplyAlways mode that will apply updated resource sets to all bound clusters whenever a change is recognized.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @alejandroEsc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign justinsb after the PR has been reviewed.
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@killianmuldoon
Copy link
Contributor

Does this directly address #4807 ? @alejandroEsc

@alejandroEsc
Copy link
Contributor Author

Does this directly address #4807 ? @alejandroEsc

Yes it does.

@dlipovetsky
Copy link
Contributor

Discussed this in the Feb 23 2022 office hours. A recap:

ClusterResourceSet is experimental, and updating its functionality is part of its experimental nature. The project offers no API guarantees; CRS can be deprecated at any time.

However, because there may be enough time to implement a longer-term alternative to ClusterResourceSet before the next minor release, some maintiners would like additional time to consider the alternative, before merging this PR.

@vincepri
Copy link
Member

/hold

Until further discussions on the addons RFE #5491 and related proposals

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2022
@joejulian
Copy link
Contributor

@vincepri I'm confused. We had discussed your desire to block this and there didn't seem to be any community consensus to do so. I don't see any reason to not let this move forward because CRS is experimental and changes to it have no bearing on the outcome of #5491.

@g-gaston Do you want to add anything? This affects your project as well, as I understand it.

@alejandroEsc
Copy link
Contributor Author

alejandroEsc commented Apr 29, 2022

closing as we are not considering this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants