Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Work around lack of kubebuilder-tools for darwin/arm64 #6092

Merged

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Feb 9, 2022

What this PR does / why we need it:

When I run make test on my M1 Mac, I get:

% make test
unable to fetch checksum for requested version: unable fetch metadata for kubebuilder-tools-1.23.3-darwin-arm64.tar.gz -- got status "404 Not Found" from GCS
KUBEBUILDER_ASSETS="" go test ./...
<numerous test failures of course>

Overriding with the equivalent of GOARCH=amd64 works fine.

Which issue(s) this PR fixes:

N/A

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@mboersma
Copy link
Contributor Author

mboersma commented Feb 9, 2022

/assign @devigned

@vincepri
Copy link
Member

Is it not possible to build them today?

@vincepri
Copy link
Member

We might need a PR to this branch https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases

@sbueringer
Copy link
Member

sbueringer commented Feb 10, 2022

We might need a PR to this branch https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases

I think this branch does not define for which GOOS/GOARCH the job is run (https://github.com/kubernetes-sigs/kubebuilder/blob/tools-releases/build/cloudbuild_tools.yaml)

But I have no idea how to find the cloud build config for that.

EDIT: Maybe it's this > https://github.com/kubernetes-sigs/kubebuilder/pull/1992/files#r573150243

@mboersma
Copy link
Contributor Author

kubernetes-sigs/kubebuilder#2516 merged, so hopefully the next release of kubebuilder-tools will offer a darwin/arm64 build.

@sbueringer
Copy link
Member

sbueringer commented Feb 24, 2022

kubernetes-sigs/kubebuilder#2516 merged, so hopefully the next release of kubebuilder-tools will offer a darwin/arm64 build.

I'm still a bit skeptical if the merged PR is enough, given: kubernetes-sigs/kubebuilder#2516 (comment)

I would be okay with merging this workaround + creating a follow-up issue for cleanup if that makes folk's lives easier until kubebuilder assets are available.

I would also expect that those might only be available after the next Kubernetes release. I would guess that the kubebuilder assets for the current releases are not necessarily automatically rebuild after a kubebuilder release.

Makefile Show resolved Hide resolved
@fabriziopandini
Copy link
Member

/retest
/lgtm

+1 to get this merged and tracking cleanup as soon as artifacts are available from the kubebuilder project

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 72cd893 into kubernetes-sigs:main Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 2, 2022
@mboersma mboersma deleted the kubebuilder-tools-m1-fix branch March 7, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants