-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Work around lack of kubebuilder-tools for darwin/arm64 #6092
🐛 Work around lack of kubebuilder-tools for darwin/arm64 #6092
Conversation
/assign @devigned |
Is it not possible to build them today? |
We might need a PR to this branch https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases |
I think this branch does not define for which GOOS/GOARCH the job is run (https://github.com/kubernetes-sigs/kubebuilder/blob/tools-releases/build/cloudbuild_tools.yaml) But I have no idea how to find the cloud build config for that. EDIT: Maybe it's this > https://github.com/kubernetes-sigs/kubebuilder/pull/1992/files#r573150243 |
kubernetes-sigs/kubebuilder#2516 merged, so hopefully the next release of kubebuilder-tools will offer a darwin/arm64 build. |
I'm still a bit skeptical if the merged PR is enough, given: kubernetes-sigs/kubebuilder#2516 (comment) I would be okay with merging this workaround + creating a follow-up issue for cleanup if that makes folk's lives easier until kubebuilder assets are available. I would also expect that those might only be available after the next Kubernetes release. I would guess that the kubebuilder assets for the current releases are not necessarily automatically rebuild after a kubebuilder release. |
/retest +1 to get this merged and tracking cleanup as soon as artifacts are available from the kubebuilder project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When I run
make test
on my M1 Mac, I get:Overriding with the equivalent of
GOARCH=amd64
works fine.Which issue(s) this PR fixes:
N/A