🌱 test/e2e: deprecate KCPUpgradeSpec, make ClusterUpgradeConformanceSpec more flexible #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
commented
Dec 1, 2021
sbueringer
force-pushed
the
pr-deprecate-kcp-upgrade-e2e-test-spec
branch
from
3ec5011 to
5d6ade8
Compare
sbueringer
changed the title
sbueringer
force-pushed
the
pr-deprecate-kcp-upgrade-e2e-test-spec
branch
from
5d6ade8 to
394539b
Compare
sbueringer
force-pushed
the
pr-deprecate-kcp-upgrade-e2e-test-spec
branch
from
394539b to
8a3a248
Compare
|
Addressed the review findings Let's |
k8s-ci-robot
added
the
do-not-merge/hold
…c more flexible Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-deprecate-kcp-upgrade-e2e-test-spec
branch
from
8a3a248 to
c364d67
Compare
|
/test pull-cluster-api-e2e-full-main |
|
/hold cancel e2e-full test is green |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4896