Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt strings #524

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Conversation

alvaroaleman
Copy link
Member

What this PR does / why we need it:

Without this patch, make fails on go 1.11 with a

# sigs.k8s.io/cluster-api/cmd/clusterctl/clusterdeployer/clusterclient
cmd/clusterctl/clusterdeployer/clusterclient/clusterclient.go:592: Warningf format %v reads arg #2, but call has 1 arg
# sigs.k8s.io/cluster-api/cmd/clusterctl/clusterdeployer
cmd/clusterctl/clusterdeployer/clusterdeployer_test.go:814: T.Fatalf format %q has arg tc.inputMachines of wrong type []*sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha1.Machine
cmd/clusterctl/clusterdeployer/clusterdeployer_test.go:818: T.Fatalf format %q has arg tc.inputMachines of wrong type []*sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha1.Machine
cmd/clusterctl/clusterdeployer/clusterdeployer_test.go:823: T.Fatalf format %q has arg tc.inputMachines of wrong type []*sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha1.Machine
cmd/clusterctl/clusterdeployer/clusterdeployer_test.go:827: T.Fatalf format %q has arg tc.inputMachines of wrong type []*sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha1.Machine

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2018
@alvaroaleman
Copy link
Member Author

/assign @roberthbailey

@alvaroaleman
Copy link
Member Author

cc @xmudrii

@xmudrii
Copy link
Member

xmudrii commented Oct 6, 2018 via email

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2018
@alvaroaleman
Copy link
Member Author

/test pull-cluster-api-test

@alvaroaleman
Copy link
Member Author

/retest

All the failed tests have a timeout waiting for process kube-apiserver to start on top of them, maybe that timeout is too low?

@roberthbailey
Copy link
Contributor

@pwittrock ^^

@roberthbailey
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit a30de81 into kubernetes-sigs:master Oct 7, 2018
@alvaroaleman alvaroaleman deleted the fix-fmt-strings branch October 7, 2018 15:53
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
VMService interface and implementation using govmomi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants