🌱 update upstream k8s CI image store reference #4922
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jackfrancis @CecileRobertMichon Do you know where we reference those images? |
Looks like #4107 already addressed most references |
Ah thx, that explains why I couldn't find it. /lgtm |
k8s-ci-robot
added
the
lgtm
Although that's only the conformance image. At least in CAPD I would assume we're not using them |
| @@ -95,7 +95,7 @@ if [[ "$${KUBERNETES_VERSION}" != "" ]]; then | |||
| $${GSUTIL} cp "$${CI_URL}/$${CI_CONTAINER}.$${CONTAINER_EXT}" "$${CI_DIR}/$${CI_CONTAINER}.$${CONTAINER_EXT}" | |||
| $${SUDO} ctr -n k8s.io images import "$${CI_DIR}/$${CI_CONTAINER}.$${CONTAINER_EXT}" || echo "* ignoring expected 'ctr images import' result" | |||
| $${SUDO} ctr -n k8s.io images tag "k8s.gcr.io/$${CI_CONTAINER}-amd64:$${KUBERNETES_VERSION//+/_}" "k8s.gcr.io/$${CI_CONTAINER}:$${KUBERNETES_VERSION//+/_}" | |||
| $${SUDO} ctr -n k8s.io images tag "k8s.gcr.io/$${CI_CONTAINER}-amd64:$${KUBERNETES_VERSION//+/_}" "gcr.io/kubernetes-ci-images/$${CI_CONTAINER}:$${KUBERNETES_VERSION//+/_}" | |||
| $${SUDO} ctr -n k8s.io images tag "k8s.gcr.io/$${CI_CONTAINER}-amd64:$${KUBERNETES_VERSION//+/_}" "gcr.io/k8s-staging-ci-images/$${CI_CONTAINER}:$${KUBERNETES_VERSION//+/_}" | |||
There was a problem hiding this comment.
In case you want to try out my suggestion here: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1512/files#r668146228
I would wait for the results of testing this before we merge.
There was a problem hiding this comment.
As seen in the other PR. We need the tags as kubeadm will try to pull images from there (the repo is hard-coded in kubeadm). The repo was changed in kubeadm for all versions >= 1.18.
jackfrancis
force-pushed
the
k8s-staging-ci-images
branch
from
58b265e to
248460e
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Tested on CAPA, and conformance suite started successfully. /lgtm /assign @fabriziopandini |
|
#4420 now includes these changes, so let's get that one in. |
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
|
/close |
|
@CecileRobertMichon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR updates a cluster-api CI reference to a deprecated upstream with the new URI.
We did this in capz as well, as described here:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #