🌱Remove go-bindata #4378
🌱Remove go-bindata #4378
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
| @@ -1,285 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
was this removed intentionally? I don't see it being replaced with embed in this PR
There was a problem hiding this comment.
This was replaced by go embed in the previous PR, those are left-overs
|
:sad I have to investigate why Kustomise on my machine splits descriptions on many line, while in CI not... |
|
@fabriziopandini Might want to try to |
fabriziopandini
force-pushed
the
remove-gobindata
branch
from
05fa1c6 to
3d3dd08
Compare
|
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@vincepri this should be ready to go now, thanks for the tip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR is a follow up of #4350 and it removes the remaining go-bindata bits in favour of native golang "embed" introduced in v1.16.
Which issue(s) this PR fixes