-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Start adding KubeadmControlPlane controller #1826
✨ Start adding KubeadmControlPlane controller #1826
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
700c4bb
to
da1a67e
Compare
For testing I used the following yaml: ---
kind: AWSMachineTemplate
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha3
metadata:
name: kcp-infra-template
namespace: default
spec:
template:
spec:
instanceType: t3.large
iamInstanceProfile: "nodes.cluster-api-provider-aws.sigs.k8s.io"
---
kind: KubeadmControlPlane
apiVersion: cluster.x-k8s.io/v1alpha3
metadata:
name: kcp-1
namespace: default
spec:
infrastructureTemplate:
name: kcp-infra-template
namespace: default
kubeadmConfigSpec:
clusterConfiguration:
version: v1.16.2 With this I was able to see the log lines indicating that the controller is not yet implemented. |
/assign @ncdc |
Do you want this to get merged as-is (pending review), then do a follow-up for the real implementation? |
I figured we could start with a stubbed out implementation and start building up the needed functionality iteratively. I'm hoping to keep down the bandwidth needed for reviewing (and the breakage for testing) to a minimum as we work towards the full implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Nothing major in my comments. Mostly nits & some small questions.
#1836 should fix the integration test flake |
/retest |
da1a67e
to
025d3d3
Compare
025d3d3
to
ef2206b
Compare
@ncdc @randomvariable this should be ready for another pass now. |
/lgtm |
What this PR does / why we need it:
Adds the stubbing for the KubeadmControlPlane controller
Related to: #1756