Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Start adding KubeadmControlPlane controller #1826

Merged

Conversation

detiber
Copy link
Member

@detiber detiber commented Dec 3, 2019

What this PR does / why we need it:

Adds the stubbing for the KubeadmControlPlane controller

Related to: #1756

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2019
@detiber detiber force-pushed the kubeadmControlPlaneController branch 5 times, most recently from 700c4bb to da1a67e Compare December 4, 2019 22:17
@detiber detiber changed the title [WIP] ✨ Start adding KubeadmControlPlane controller ✨ Start adding KubeadmControlPlane controller Dec 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2019
@detiber
Copy link
Member Author

detiber commented Dec 4, 2019

For testing I used the following yaml:

---
kind: AWSMachineTemplate
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha3
metadata:
  name: kcp-infra-template
  namespace: default
spec:
  template:
    spec:
      instanceType: t3.large
      iamInstanceProfile: "nodes.cluster-api-provider-aws.sigs.k8s.io"
---
kind: KubeadmControlPlane
apiVersion: cluster.x-k8s.io/v1alpha3
metadata:
  name: kcp-1
  namespace: default
spec:
  infrastructureTemplate:
    name: kcp-infra-template
    namespace: default
  kubeadmConfigSpec:
    clusterConfiguration:
  version: v1.16.2

With this I was able to see the log lines indicating that the controller is not yet implemented.

@detiber
Copy link
Member Author

detiber commented Dec 4, 2019

/assign @ncdc

@ncdc
Copy link
Contributor

ncdc commented Dec 4, 2019

Do you want this to get merged as-is (pending review), then do a follow-up for the real implementation?

@detiber
Copy link
Member Author

detiber commented Dec 4, 2019

Do you want this to get merged as-is (pending review), then do a follow-up for the real implementation?

I figured we could start with a stubbed out implementation and start building up the needed functionality iteratively.

I'm hoping to keep down the bandwidth needed for reviewing (and the breakage for testing) to a minimum as we work towards the full implementation.

Copy link
Contributor

@ncdc ncdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Nothing major in my comments. Mostly nits & some small questions.

controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
@ncdc
Copy link
Contributor

ncdc commented Dec 4, 2019

#1836 should fix the integration test flake

@randomvariable
Copy link
Member

/retest

@chuckha chuckha mentioned this pull request Dec 5, 2019
33 tasks
@detiber detiber force-pushed the kubeadmControlPlaneController branch from da1a67e to 025d3d3 Compare December 5, 2019 16:58
@detiber detiber force-pushed the kubeadmControlPlaneController branch from 025d3d3 to ef2206b Compare December 5, 2019 17:13
@detiber
Copy link
Member Author

detiber commented Dec 5, 2019

@ncdc @randomvariable this should be ready for another pass now.

@ncdc ncdc added this to the v0.3.0 milestone Dec 5, 2019
@ncdc ncdc added the area/control-plane Issues or PRs related to control-plane lifecycle management label Dec 5, 2019
@ncdc
Copy link
Contributor

ncdc commented Dec 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 900a2ff into kubernetes-sigs:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Issues or PRs related to control-plane lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants