Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖CAEP: MachinePool API (provider agnostic scale types) #1703

Merged
merged 1 commit into from
Dec 11, 2019
Merged

📖CAEP: MachinePool API (provider agnostic scale types) #1703

merged 1 commit into from
Dec 11, 2019

Conversation

juan-lee
Copy link
Contributor

@juan-lee juan-lee commented Oct 31, 2019 •
edited
Loading

Signed-off-by: Juan-Lee Pang [email protected]

What this PR does / why we need it:
Adds CAEP for MachinePool (provider agnostic scale types).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc October 31, 2019 14:09
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2019
@vincepri vincepri changed the title CAEP: MachinePool API (provider agnostic scale types) 📖CAEP: MachinePool API (provider agnostic scale types) Oct 31, 2019
@ncdc ncdc added the kind/proposal Issues or PRs related to proposals. label Oct 31, 2019
@ncdc ncdc added this to the v0.3.0 milestone Oct 31, 2019
@ncdc ncdc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 31, 2019
@juan-lee juan-lee force-pushed the machinepool-caep-doc branch from a55eba2 to 1e81a11 Compare November 6, 2019 12:21
@vincepri vincepri self-assigned this Nov 6, 2019
jzhoucliqr
jzhoucliqr reviewed Nov 15, 2019
View reviewed changes
@juan-lee juan-lee force-pushed the machinepool-caep-doc branch from 1e81a11 to 6796f90 Compare November 24, 2019 16:04
@juan-lee juan-lee mentioned this pull request Nov 24, 2019
Closed
@juan-lee juan-lee force-pushed the machinepool-caep-doc branch from 6796f90 to 7c46067 Compare November 24, 2019 17:46
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2019
ncdc
ncdc reviewed Dec 3, 2019
View reviewed changes
docs/proposals/20190919-machinepool-api.md Outdated

###### Expectations

- Nodes associated with MachinePool should be cordoned and drained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned above that cordon & drain is out of scope for this initial work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. I removed this line. I'd like to be able to add cordon and drain support after we get initial MachinePool support in.

@ncdc
Copy link
Contributor

ncdc commented Dec 3, 2019

Generally LGTM & ready to approve pending addressing my comments. Thanks!

@juan-lee
CAEP: MachinePool API (provider agnostic scale types)
423d06e 
Signed-off-by: Juan-Lee Pang [email protected]

What this PR does / why we need it:
Adds CAEP for  MachinePool (provider agnostic scale types).
@juan-lee juan-lee force-pushed the machinepool-caep-doc branch from 7c46067 to 423d06e Compare December 4, 2019 03:26
@ncdc
Copy link
Contributor

ncdc commented Dec 4, 2019

@detiber @justaugustus @vincepri @chuckha @jzhoucliqr any additional comments?

@justaugustus
Copy link

I need to do another sweep. Hopefully before the week is out!
/cc

@juan-lee
Copy link
Contributor Author

juan-lee commented Dec 4, 2019

I need to do another sweep. Hopefully before the week is out!
/cc

Do you mind if we merge and address any new comments you have out of band @justaugustus? @ncdc

@ncdc
Copy link
Contributor

ncdc commented Dec 4, 2019

Totally fine with me

@justaugustus
Copy link

@juan-lee -- Sounds good to me!

For capz:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@juan-lee
Copy link
Contributor Author

juan-lee commented Dec 4, 2019

/assign @vincepri

@ncdc
Copy link
Contributor

ncdc commented Dec 4, 2019

Let's start lazy consensus: expiration next Wednesday, December 11

@ncdc ncdc requested review from vincepri and removed request for justinsb December 4, 2019 21:00
@enxebre enxebre mentioned this pull request Dec 11, 2019
Closed
@ncdc
Copy link
Contributor

ncdc commented Dec 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan-lee, justaugustus, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 20d7b50 into kubernetes-sigs:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha chuckha left review comments

@jzhoucliqr jzhoucliqr jzhoucliqr left review comments

@ncdc ncdc ncdc approved these changes

@detiber detiber detiber approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@justaugustus justaugustus

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/proposal Issues or PRs related to proposals. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
8 participants
@juan-lee @ncdc @justaugustus @k8s-ci-robot @chuckha @detiber @jzhoucliqr @vincepri