🌱 Refine v1beta2 ControlPlaneHealthy condition #11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/control-plane-kubeadm
k8s-ci-robot
added
the
size/M
fabriziopandini
force-pushed
the
refine-v1beta2-controlplanehealthy-condition
branch
from
ebcca99
to
d97d232
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9a02c81dc82a9ef49fef52959fe20e8792a16973
|
|
/retitle 🌱 Refine v1beta2 ControlPlaneHealthy condition |
k8s-ci-robot
changed the title
sbueringer
reviewed
Nov 19, 2024
fabriziopandini
force-pushed
the
refine-v1beta2-controlplanehealthy-condition
branch
from
d97d232
to
a8cd67e
Compare
k8s-ci-robot
removed
the
lgtm
fabriziopandini
force-pushed
the
refine-v1beta2-controlplanehealthy-condition
branch
from
a8cd67e
to
c29be33
Compare
|
/lgtm Thx! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: eeac326d128b90e2205348a685a4d39ca38b0a54
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
force-pushed
the
refine-v1beta2-controlplanehealthy-condition
branch
from
c29be33
to
ff04abc
Compare
k8s-ci-robot
removed
the
lgtm
sbueringer
force-pushed
the
refine-v1beta2-controlplanehealthy-condition
branch
from
ff04abc
to
f136ddf
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 757e25ec8e766f28b75272e0a15a999acc92bb44
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refine KCP's ControlPlaneHealthy condition by grouping conditions when they all have the same message
/area provider/control-plane-kubeadm
Part of #11105