Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize provider specific specs and status in separated CRDs #1137

Merged
merged 7 commits into from
Jul 19, 2019
Merged

Externalize provider specific specs and status in separated CRDs #1137

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b141c0
WIP: Initial Proposal
Jul 6, 2019
af14bfb
Address review comments
pablochacin Jul 14, 2019
64e5ae9
Update state transition model
pablochacin Jul 14, 2019
0b17541
Fix typos. Regenerate TOC
pablochacin Jul 15, 2019
1259b0c
Make explicit status fields copied
pablochacin Jul 18, 2019
10d81d8
Fix asciiart diagrams
pablochacin Jul 18, 2019
31a03f2
Fix list of reviewers
pablochacin Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/proposals/20190709-cluster-spec-crds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ reviewers:
- "@ncdc"
- "@vincepri"
pablochacin marked this conversation as resolved.
Show resolved Hide resolved
creation-date: 2019-07-09
last-updated: 2019-07-14
last-updated: 2019-07-18
status: provisional
see-also:
- "/docs/proposals/20190610-machine-states-preboot-bootstrapping.md"
Expand Down Expand Up @@ -185,7 +185,7 @@ The sequence diagram below describes the high-level process, collaborations and
| | | IF Infrastructure.Status.Ready | |
| | | | | | |
| | | Update Cluster Status | | | |
| | | from Infrastructure Status | |
| | | from Infrastructure Status | |
| |<-+-------------------------| | | |
| | | | | | |
| | | Set Cluster.Status.InfrastructureReady | |
Expand All @@ -208,7 +208,7 @@ When the cluster object is created, the cluster controller will retrieve the inf

When an infrastructure object is updated, the provider controller will check the owner reference. If it is set, it will retrieve the cluster object to obtain the required cluster specification and starts the provisioning process. When the process finishes, it sets the `Infrastructure.Status.Ready` to true.

When the cluster controller detects the `Infrastructure.Status.Ready` is set to true, it updates the Cluster status with information from `Infrastructure.Status` (e.g. `APIEndpoint`) and sets `Cluster.Status.InfrastructureReady` to true.
When the cluster controller detects the `Infrastructure.Status.Ready` is set to true, it updates `Cluster.Status.APIEndpoint` from `Infrastructure.Status.APIEndpoint` and sets `Cluster.Status.InfrastructureReady` to true.
ncdc marked this conversation as resolved.
Show resolved Hide resolved

### States and Transitions
pablochacin marked this conversation as resolved.
Show resolved Hide resolved

Expand Down Expand Up @@ -319,7 +319,7 @@ TODO
- [x] 06/19/2009 [Discussed](https://github.com/kubernetes-sigs/cluster-api/issues/833#issuecomment-501380522) the inclusion in the scope of v1alpha2.
- [x] 07/09/2019 initial version of the proposal created
- [X] 07/11/2019 Presentation of proposal to the community
- [ ] Feedback
- [X] Feedback

## Drawbacks [optional]

Expand Down