Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Promote feature CRS to GA #11365

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mcbenjemaa
Copy link
Member

@mcbenjemaa mcbenjemaa commented Nov 1, 2024

What this PR does / why we need it:
Promote ClusterResourceSet to GA,
Make the CRS feature GA and enabled by default, and make the CRS feature clear in the API and documentation.
the code organization will be held in following PR after this is released

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Ref #11114

/area api
/area clusterresourceset
/area documentation

@k8s-ci-robot k8s-ci-robot added area/api Issues or PRs related to the APIs area/clusterresourceset Issues or PRs related to clusterresourcesets area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2024
@mcbenjemaa
Copy link
Member Author

/cc fabriziopandini

@mcbenjemaa mcbenjemaa changed the title ✨ promote CRS to GA ✨ Promote CRS to GA Nov 1, 2024
@mcbenjemaa mcbenjemaa changed the title ✨ Promote CRS to GA ✨ Promote feature CRS to GA Nov 1, 2024
@mcbenjemaa mcbenjemaa force-pushed the crs-ga branch 3 times, most recently from b5a503b to 653f6f0 Compare November 4, 2024 15:57
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@fabriziopandini
Copy link
Member

@mcbenjemaa It would be nice if we can rebase this PR
@chrischdi @vincepri @enxebre What is your opinion about graduating CRS to GA? (follow up of the work to assess all the existing feature flags).

I'm personally +1, considering we did a good work to define scope and limitations of this feature in the last iteration on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20200220-cluster-resource-set.md + we have https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20220712-cluster-api-addon-orchestration.md in case someone something more sophisticated.
(I'm also ok consider merging this after code freeze, if you need some more time)

@chrischdi
Copy link
Member

@mcbenjemaa It would be nice if we can rebase this PR @chrischdi @vincepri @enxebre What is your opinion about graduating CRS to GA? (follow up of the work to assess all the existing feature flags).

I'm personally +1, considering we did a good work to define scope and limitations of this feature in the last iteration on main/docs/proposals/20200220-cluster-resource-set.md + we have main/docs/proposals/20220712-cluster-api-addon-orchestration.md in case someone something more sophisticated. (I'm also ok consider merging this after code freeze, if you need some more time)

I'm good with getting this to GA.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f93d562e33f79fc162196a0d5d62e257a96a5ad4

@mcbenjemaa
Copy link
Member Author

So this should go to v1.9 or to the next one?

@fabriziopandini
Copy link
Member

We are not in rush, Let's move to 1.10
But let's bring this up in one of the next office hours, so we can hopefully get some traction + set a lazy consensus and try to get this out of the table soon

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from my side, just nits

exp/addons/api/v1beta1/clusterresourceset_types.go Outdated Show resolved Hide resolved
feature/feature.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

@mcbenjemaa Do you have time to address @chrischdi's findings above? I think once these are fixed we can merge the PR

@mcbenjemaa
Copy link
Member Author

I'm ready

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 17, 2025
@sbueringer
Copy link
Member

Thank you!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@elmiko
Copy link
Contributor

elmiko commented Jan 17, 2025

changes lgtm, i'll leave the tag to another though as i'm just reviewing this for the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs area/clusterresourceset Issues or PRs related to clusterresourcesets area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants