Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add classNamespace to topology #11352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add classNamespace to topology #11352

wants to merge 1 commit into from

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Oct 30, 2024 •
edited
Loading

What this PR does / why we need it:

Adding classNamespace variable to the cluster topology, which allows to point to a ClusterClass in a different namespace. This field is dormant, and is used for differentiation only.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #5673

/area clusterclass

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2024
@Danil-Grigorev Danil-Grigorev changed the title Add classNamespace to topology ✨ Add classNamespace to topology Oct 30, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch 2 times, most recently from ae1cb19 to 43cb995 Compare October 30, 2024 11:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch 2 times, most recently from 2bddeeb to 352fd66 Compare October 30, 2024 15:20
salasberryfin
salasberryfin reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Danil-Grigorev! I added a small suggestion but I think this looks good.

docs/book/src/tasks/experimental-features/cluster-class/write-clusterclass.md Outdated Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch from 352fd66 to bd8a56f Compare October 31, 2024 09:51
@salasberryfin
Copy link
Contributor

Thanks @Danil-Grigorev

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4b418743a4683ae623b3264aae7636c41ad5675

@salasberryfin
Copy link
Contributor

/assign @chrischdi

@Danil-Grigorev Danil-Grigorev changed the title ✨ Add classNamespace to topology [WIP] ✨ Add classNamespace to topology Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch from bd8a56f to 4bbb218 Compare October 31, 2024 18:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch from 4bbb218 to d450768 Compare October 31, 2024 18:44
@Danil-Grigorev Danil-Grigorev changed the title [WIP] ✨ Add classNamespace to topology ✨ Add classNamespace to topology Oct 31, 2024
@Danil-Grigorev Danil-Grigorev mentioned this pull request Jan 7, 2025
Open
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch 3 times, most recently from 03780fe to 1ae95a5 Compare January 9, 2025 21:07
sbueringer
sbueringer reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this and thx for the patience. Sorry for the delay

api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/cluster_types.go Show resolved Hide resolved
api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
internal/webhooks/clusterclass.go Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jan 10, 2025
Open
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 13, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch 3 times, most recently from 067fcc5 to 21ec29a Compare January 14, 2025 07:52
sbueringer
sbueringer reviewed Jan 14, 2025
View reviewed changes
api/v1beta1/index/cluster.go Show resolved Hide resolved
api/v1beta1/index/cluster.go Outdated Show resolved Hide resolved
api/v1beta1/index/cluster.go Outdated Show resolved Hide resolved
docs/book/src/tasks/experimental-features/cluster-class/write-clusterclass.md Outdated Show resolved Hide resolved
internal/topology/check/compatibility_test.go Outdated Show resolved Hide resolved
api/v1beta1/index/cluster.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

@Danil-Grigorev Just a few minor comments

@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch 2 times, most recently from 681bdbd to ebdc21d Compare January 15, 2025 16:02
sbueringer
sbueringer reviewed Jan 15, 2025
View reviewed changes
api/v1beta1/index/cluster.go Outdated Show resolved Hide resolved
api/v1beta1/index/cluster.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility_test.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility_test.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility_test.go Outdated Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch 3 times, most recently from 2b2278a to 9a67d48 Compare January 16, 2025 12:56
sbueringer
sbueringer reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very last nit. Please squash the commits. I don't remember the details but I'm not sure if we have some problems with merge commits

api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch from c68381d to dd90304 Compare January 17, 2025 12:28
@Danil-Grigorev
Add classNamespace to topology
ecdfa14 
- Add documentation on securing cross-namespace access for CC
- Add ByClusterClassRef index
- Support cross-ns CC rebase

Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-addition branch from dd90304 to ecdfa14 Compare January 17, 2025 12:47
@sbueringer
Copy link
Member

sbueringer commented Jan 17, 2025 •
edited
Loading

Thank you very much!

/lgtm

/assign @chrischdi @fabriziopandini

/hold
We should wait with merge until #11395 is also ready (it adds the corresponding e2e tests)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9360879ac2877e429557d43eba40121ab5590e79

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@enxebre enxebre enxebre left review comments

@chrischdi chrischdi chrischdi left review comments

@neolit123 neolit123 neolit123 left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@salasberryfin salasberryfin Awaiting requested review from salasberryfin

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@salasberryfin salasberryfin

@furkatgofurov7 furkatgofurov7

Labels
area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.