Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block on unsupported Kubernetes version #4321

Closed
fabriziopandini opened this issue Mar 15, 2021 · 8 comments
Closed

Block on unsupported Kubernetes version #4321

fabriziopandini opened this issue Mar 15, 2021 · 8 comments
Labels
area/bootstrap Issues or PRs related to bootstrap providers area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@fabriziopandini
Copy link
Member

User Story

As a operator, I would like to get informed about unsupported Kubernetes versions when creating resources.

Detailed Description

As per #4292 (comment)

CABPK currently supports only Kubernetes versions >= v1.13, but the user does not get an error message when creating Machines/MachineDeployments/KubeadmControlPlane with older version

Anything else you would like to add:

This is tricky, because in some cases the kubernetes version could be defined on another resources vs the KubeadmConfig/KubeadmConfigTemplate (e.g. Machines, Machine deployments), and those resurces are generic - should not be bound to CABPK limitations.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 15, 2021
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0
/area bootstrap
/area control plane
/priority backlog

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added the area/bootstrap Issues or PRs related to bootstrap providers label Mar 15, 2021
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/control, area/plane cannot be applied, because the repository doesn't have them.

In response to this:

/milestone v0.4.0
/area bootstrap
/area control plane
/priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 15, 2021
@fabriziopandini fabriziopandini added the area/control-plane Issues or PRs related to control-plane lifecycle management label Mar 15, 2021
@CecileRobertMichon
Copy link
Contributor

Is this a duplicate of #3697 ?

@fabriziopandini
Copy link
Member Author

#3697 is about semantic validation of the version
This is issue is about the fact the CABPK supports only a subset of Kubernetes versions ( >= v1.13)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2021
@vincepri
Copy link
Member

/lifecycle frozen

@fabriziopandini What are some action items we can take as part of this issue?

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 21, 2021
@vincepri vincepri modified the milestones: v0.4, v1.1 Oct 22, 2021
@fabriziopandini fabriziopandini modified the milestones: v1.1, v1.2 Feb 3, 2022
@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini fabriziopandini removed this from the v1.2 milestone Jul 29, 2022
@fabriziopandini fabriziopandini removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini
Copy link
Member Author

/close
in favor of #7010

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

/close
in favor of #7010

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Issues or PRs related to bootstrap providers area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants