Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support #2218

Closed
4 tasks
rhockenbury opened this issue Jan 30, 2020 · 14 comments
Closed
4 tasks

Windows Support #2218

rhockenbury opened this issue Jan 30, 2020 · 14 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@rhockenbury
Copy link

rhockenbury commented Jan 30, 2020

User Story

As an operator, I would like to manage windows server worker nodes with the cluster api.

Detailed Description

Since I just went through setting up windows nodes to work with the cluster api (CAPV), I'm documenting areas of improvements / issues for better supporting windows nodes.

Anything else you would like to add:

Windows worker nodes are not officially support by the cluster api, but it is up for discussion about where it belongs in the roadmap - https://github.com/kubernetes-sigs/cluster-api/pull/2148/files#diff-767f66541aad47089dd5ded720dede6bR32.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 30, 2020
@ksubrmnn
Copy link

Hi @rhockenbury I'm currently working on this, and I've already created a POC here. I will be working on the design for this in the next month regarding the bootstrap provider and will put up the design and PR soon.

@ksubrmnn
Copy link

/assign @ksubrmnn

@rhockenbury
Copy link
Author

That sounds great. Did you have any thoughts about #2217 ?

@michmike
Copy link

cc: @benmoss

@ncdc ncdc added this to the Next milestone Feb 5, 2020
@ksubrmnn
Copy link

ksubrmnn commented Feb 5, 2020

That sounds great. Did you have any thoughts about #2217 ?

Yes, that's an issue that I have in my POC. I currently just work around it via hardcoding (not great). I think we'd have to open this to a broader community discussion to agree upon a standard. Perhaps this should be discussed in the overall CAPI meeting.

Other than that, I haven't found any other significant differences beyond the bootstrap script (I've created my own that uses the KubeCluster scripts in sig-windows tools).

In my implementation we are using custom script extensions (as is custom for Azure). Haven't had a chance to read up on @benmoss 's work.

@JocelynBerrendonner ill also be working on this from MSFT.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2020
@vincepri
Copy link
Member

vincepri commented May 5, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2020
@detiber
Copy link
Member

detiber commented Aug 3, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2020
@CecileRobertMichon
Copy link
Contributor

/lifecycle active
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 22, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v0.4.0 Sep 22, 2020
@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 22, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Dec 21, 2020
@fabriziopandini
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 30, 2020
@CecileRobertMichon
Copy link
Contributor

/close

The proposal (#3616) has been merged and image-builder / infra provider implementations are underway

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closing this issue.

In response to this:

/close

The proposal (#3616) has been merged and image-builder / infra provider implementations are underway

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

10 participants