Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use dl.k8s.io instead of hardcoded GCS URIs #1910

Merged
merged 1 commit into from
May 11, 2023
Merged

🌱 Use dl.k8s.io instead of hardcoded GCS URIs #1910

merged 1 commit into from
May 11, 2023

Conversation

stmcginnis
Copy link
Contributor

What this PR does / why we need it*:

The storage.googleapis.com/kubernetes-release URL is a hard coded path to a GCS bucket location. To allow redirecting and spreading the load across multiple hosting locations, the dl.k8s.io URL has been introduced.

Which issue(s) this PR fixes:

Related PRs:

Special notes for your reviewer:

None

Release note:

NONE

The `storage.googleapis.com/kubernetes-release` URL is a hard coded path
to a GCS bucket location. To allow redirecting and spreading the load
across multiple hosting locations, the `dl.k8s.io` URL has been
introduced.

Signed-off-by: Sean McGinnis <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2023
@k8s-ci-robot k8s-ci-robot requested review from MaxRink and srm09 May 11, 2023 14:30
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2023
@srm09
Copy link
Contributor

srm09 commented May 11, 2023

/lgtm
/approve
/cherry-pick release-1.6
/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@srm09: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.6
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5c71b19 into kubernetes-sigs:main May 11, 2023
@k8s-infra-cherrypick-robot

@srm09: new pull request created: #1911

In response to this:

/lgtm
/approve
/cherry-pick release-1.6
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@srm09: new pull request created: #1912

In response to this:

/lgtm
/approve
/cherry-pick release-1.6
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants