Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖Fix broken link #957

Merged
merged 1 commit into from
Aug 4, 2021
Merged

📖Fix broken link #957

merged 1 commit into from
Aug 4, 2021

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@jichenjc jichenjc mentioned this pull request Jul 30, 2021
Closed
@hidekazuna
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
tobiasgiese
tobiasgiese reviewed Jul 30, 2021
View reviewed changes
docs/book/src/topics/external-cloud-provider.md Outdated
@@ -1,6 +1,6 @@
# External Cloud Provider

To deploy a cluster using [external cloud provider](https://github.com/kubernetes/cloud-provider-openstack), create a cluster configuration with the [external cloud provider template](../templates/cluster-template-external-cloud-provider.yaml).
To deploy a cluster using [external cloud provider](https://github.com/kubernetes/cloud-provider-openstack), create a cluster configuration with the [external cloud provider template](../../../../templates/cluster-template-external-cloud-provider.yaml).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh, I don't think that this is the correct solution, as the book will/can be build.

Suggested change
To deploy a cluster using [external cloud provider](https://github.com/kubernetes/cloud-provider-openstack), create a cluster configuration with the [external cloud provider template](../../../../templates/cluster-template-external-cloud-provider.yaml).
To deploy a cluster using [external cloud provider](https://github.com/kubernetes/cloud-provider-openstack), create a cluster configuration with the [external cloud provider template](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/templates/cluster-template-external-cloud-provider.yaml).

Maybe this would be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @jichenjc @hidekazuna

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for e.g., docs/book/src/clusteropenstack/configuration.md

Copy link
Contributor

@hidekazuna hidekazuna Jul 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasgiese Thanks. I actually build book and confirmed original solution does not work and your proposition works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks~ , I didn't notice this as we used to have such link before , will update :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don‘t think that my suggestion is correct either. Do we publish the book somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far ,not yet, but we do have a plan though not execute it ...

@hidekazuna
Copy link
Contributor

/lgtm cancel

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, raildo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hidekazuna
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2021
@tobiasgiese
Copy link
Member

How do we proceed with the other broken links, like e.g. docs/book/src/clusteropenstack/configuration.md?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2021
@jichenjc
Copy link
Contributor Author

jichenjc commented Aug 3, 2021

@tobiasgiese updated the file you pointed out , thanks~
I searched and didn't find other occurance..

@tobiasgiese
Copy link
Member

@tobiasgiese updated the file you pointed out , thanks~
I searched and didn't find other occurance..

@jichenjc That looks better :)
We have to keep in mind that we're not able to jump between these links in a custom branch with the book built. But I think that's something we can ignore.

@hidekazuna
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2021
@jichenjc
Copy link
Contributor Author

jichenjc commented Aug 4, 2021

/hold cancel

let's get this

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5e92c92 into kubernetes-sigs:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgiese tobiasgiese tobiasgiese left review comments

@hidekazuna hidekazuna hidekazuna left review comments

@raildo raildo raildo approved these changes

@prankul88 prankul88 Awaiting requested review from prankul88

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

Assignees

@hidekazuna hidekazuna

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jichenjc @hidekazuna @k8s-ci-robot @tobiasgiese @raildo