-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Fix Webhook names for OpenStackMachineTemplate and OpenStackCluster #945
✨ Fix Webhook names for OpenStackMachineTemplate and OpenStackCluster #945
Conversation
Hi @tobiasgiese. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Tobias Giese <[email protected]>
ef63f9b
to
a0cf8dc
Compare
had to rebase... could you please take a look again @sbueringer @jichenjc :) |
/lgtm |
/lgtm |
What this PR does / why we need it:
This PR fixes the Webhook names for the
OpenStackMachineTemplate
andOpenStackCluster
.As this fix is only for the webhook names (i.e.,
ValidatingWebhookConfiguration.webhooks.name
andMutatingWebhookConfiguration.webhooks.name
), it should only be updated.diff of
kubectl kustomize
Special notes for your reviewer:
TODOs:
/hold