Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the kubernetesversions package of the cluster-api repo again #905

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Use the kubernetesversions package of the cluster-api repo again #905

merged 1 commit into from
Jul 15, 2021

Conversation

sbueringer
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2021
@sbueringer sbueringer mentioned this pull request Jun 10, 2021
Merged
@sbueringer sbueringer force-pushed the pr-finalize-inject-debian-script branch from 57655c9 to 02a47f1 Compare July 13, 2021 20:19
@sbueringer sbueringer changed the title [WIP] just a test for the corresponding CAPI PR Use the kubernetesversions package of the cluster-api repo again Jul 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2021
@sbueringer
Copy link
Member Author

/cc @hidekazuna @jichenjc @seanschneeweiss @chrischdi

As my PR in cluster-api has been merged let's drop our fork of the package.

chrischdi
chrischdi reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight Forward

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@hidekazuna
Copy link
Contributor

Great.

/unfold

@jichenjc
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-openstack-e2e-test

(testing again after the sshuttle fix)

@sbueringer
Copy link
Member Author

/retest

2 similar comments
@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

This commit already had a green test run so I assume it's just the flake and keep retrying
/retest

@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 87ec219 into kubernetes-sigs:master Jul 15, 2021
@sbueringer sbueringer deleted the pr-finalize-inject-debian-script branch July 15, 2021 19:23
@spiffxp spiffxp mentioned this pull request Jul 16, 2021
Closed
42 tasks
@spiffxp
Copy link
Member

spiffxp commented Jul 16, 2021

ref: kubernetes/k8s.io#2318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@prankul88 prankul88 Awaiting requested review from prankul88

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

@hidekazuna hidekazuna Awaiting requested review from hidekazuna

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sbueringer @k8s-ci-robot @hidekazuna @jichenjc @spiffxp @chrischdi