Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixup release targets and update doc accordingly #903

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 9, 2021

What this PR does / why we need it:
Updates the release targets and doc so they work again with v1alpha4.

Fixes #796

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2021
@sbueringer
Copy link
Member Author

/assign @jichenjc @hidekazuna

RELEASE.md Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-finalize-release-targets-and-doc branch from 23028f7 to 35fadb3 Compare June 11, 2021 04:44
@jichenjc
Copy link
Contributor

/lgtm

let's merge this and next time maybe someone do the release e.g 0.4.0 (as test and provide additional info if needed)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2021
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2021
@sbueringer
Copy link
Member Author

@hidekazuna @jichenjc just fyi. I'll be on vacation the next 2 weeks.

@k8s-ci-robot k8s-ci-robot merged commit 120db21 into kubernetes-sigs:master Jun 11, 2021
@sbueringer sbueringer deleted the pr-finalize-release-targets-and-doc branch June 12, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a v0.4.0.beta.0 release to verify the new release targets
4 participants