Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix webhook panic when adding managed security groups #2043

Merged
merged 1 commit into from
Apr 30, 2024
Merged

🐛 Fix webhook panic when adding managed security groups #2043

merged 1 commit into from
Apr 30, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Apr 30, 2024

Also adds fuzz tests which would have caught this and any similar issues.

Fixes: #2042

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from dulek and EmilienM April 30, 2024 14:23
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit ac7b475
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66310095878bf80008d4e717
😎 Deploy Preview https://deploy-preview-2043--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor

/lgtm
Thanks for the fix and tests!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@mdbooth
Fix webhook panic when adding managed security groups
ac7b475 
Also adds fuzz tests which would have caught this and any similar
issues.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 30, 2024

Pushed an update to fix a couple of lint errors.

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 30, 2024

/cherry-pick release-0.10

@k8s-infra-cherrypick-robot
Copy link

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huxcrux
Copy link
Contributor

huxcrux commented Apr 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@EmilienM
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 30, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit f233034 into kubernetes-sigs:main Apr 30, 2024
9 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@mdbooth: new pull request created: #2044

In response to this:

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth mdbooth deleted the issue2042 branch April 30, 2024 15:55
@mdbooth mdbooth mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek Awaiting requested review from dulek

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@EmilienM EmilienM

@huxcrux huxcrux

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPO Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAPO Panics when adding ManagedSecurityGroups
5 participants
@mdbooth @EmilienM @k8s-infra-cherrypick-robot @huxcrux @k8s-ci-robot