🌱 Move filter conversions out of /api #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoelSpeed
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Have you tested, with this PR in combination with #1920 what happens to a go.mod if you write a simple program that imports one of your v1beta1 types and just prints it out or something simple?
Would be good to see what go.mod that creates
mdbooth
force-pushed
the
filter_convert
branch
2 times, most recently
from
ef92315 to
c8b9ea2
Compare
main.go: package main
import (
"fmt"
"sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1"
)
func main() {
cluster := v1beta1.OpenStackCluster{}
fmt.Printf("%+v\n", cluster)
}go.mod: |
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jichenjc
reviewed
Mar 6, 2024
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright 2021 The Kubernetes Authors. | |||
| Copyright 2023 The Kubernetes Authors. | |||
k8s-ci-robot
added
the
lgtm
Removes a gophercloud dependency for consumers of the API.
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a gophercloud dependency for consumers of the API.
This is the complement to #1920. Together they remove most external dependencies when importing v1beta1, although due to the conversion dependency importing prior versions still also pull in controller-runtime.
/hold