-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Deprecate v1alpha6 #1900
🌱 Deprecate v1alpha6 #1900
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have no experience with how deprications have worked prior in CAPO however would it be beneficial to add information regarding deprecation and maybe a removal timeframe to docs or maybe even README? Away from the above questions I think this pr looks good :) |
Yes we should define a policy for how long we support older API versions and releases. I think we could basically copy CAPIs policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1alpha7 has been around since v0.8 so I think this is reasonable
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Mark v1alpha6 version deprecated in our Kubernetes CRDs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1886