Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Deprecate v1alpha6 #1900

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

EmilienM
Copy link
Contributor

What this PR does / why we need it:

Mark v1alpha6 version deprecated in our Kubernetes CRDs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1886

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2024
@EmilienM EmilienM changed the title Deprecate v1alpha6 🌱Deprecate v1alpha6 Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 05537fb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d649671c51330008313eef
😎 Deploy Preview https://deploy-preview-1900--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2024
@EmilienM EmilienM changed the title 🌱Deprecate v1alpha6 🌱 Deprecate v1alpha6 Feb 21, 2024
@huxcrux
Copy link
Contributor

huxcrux commented Feb 21, 2024

I have no experience with how deprications have worked prior in CAPO however would it be beneficial to add information regarding deprecation and maybe a removal timeframe to docs or maybe even README?

Away from the above questions I think this pr looks good :)

@lentzi90
Copy link
Contributor

I have no experience with how deprications have worked prior in CAPO however would it be beneficial to add information regarding deprecation and maybe a removal timeframe to docs or maybe even README?

Away from the above questions I think this pr looks good :)

Yes we should define a policy for how long we support older API versions and releases. I think we could basically copy CAPIs policy.

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1alpha7 has been around since v0.8 so I think this is reasonable
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Feb 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8801eda into kubernetes-sigs:main Feb 22, 2024
9 checks passed
@pierreprinetti pierreprinetti deleted the issue_1886 branch October 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate v1alpha6
5 participants