Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update the dev-test ClusterClass #1848

Merged

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

This adds a patch to set the image automatically based on the kubernetes version. It also removes the requirement to have the CLUSTER_NAME variable set for the ClusterClass.
Finally, the docs are updated to reflect this and with a few additions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

This adds a patch to set the image automatically based on the kubernetes
version. It also removes the requirement to have the CLUSTER_NAME
variable set for the ClusterClass.
Finally, the docs are updated to reflect this and with a few additions.

Signed-off-by: Lennart Jern <[email protected]>
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit d410f82
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65ba0ffe6346680008895e95
😎 Deploy Preview https://deploy-preview-1848--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dulek and mdbooth January 31, 2024 09:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2024
@lentzi90
Copy link
Contributor Author

/cc @maxrantil
What do you think about this update?
I moved things around a bit in the docs and added some more details in a few places 🙂

@k8s-ci-robot
Copy link
Contributor

@lentzi90: GitHub didn't allow me to request PR reviews from the following users: maxrantil.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @maxrantil
What do you think about this update?
I moved things around a bit in the docs and added some more details in a few places 🙂

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxrantil
Copy link
Contributor

It looks very good! Nice that you got the patches working with overridden-by-patch.

@maxrantil
Copy link
Contributor

LGTM

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@mdbooth
Copy link
Contributor

mdbooth commented Jan 31, 2024

/lgtm

@maxrantil Incidentally lgtm requires the leading / and is restricted to kubernetes-sigs members. The bar to joining the sig is very achievable, though. If you've got a couple of patches in other repos already you may already meet it. If not you'll find sponsors here after another couple of PRs or so.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 54d6fd0 into kubernetes-sigs:main Jan 31, 2024
9 checks passed
@lentzi90 lentzi90 deleted the lentzi90/dev-test-class-update branch January 31, 2024 12:16
@maxrantil
Copy link
Contributor

@mdbooth Thanks, I will for sure look into this and achieve it one day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants