-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: remove "allow-all-in-cluster-traffic" patch #1834
Conversation
The default rules should be sufficient for Calico which is used by e2e clusters; let's remove the allow-all-in-cluster-traffic patch which should not be needed.
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-test |
/cc @lentzi90 |
/approve test passed, should be good as we don't need allow all (Calico is default) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
/lgtm
/test pull-cluster-api-provider-openstack-e2e-test |
The default rules should be sufficient for Calico which is used by e2e
clusters; let's remove the allow-all-in-cluster-traffic patch which
should not be needed.