🐛 Fix patching OpenstackMachine's immutable spec during reconcile

[strudelPi]

What this PR does / why we need it: When a previously existing(OpenstackMachine has instanceID ref) VM vanishes (cannot be fetched from Openstack) the reconcile loop attempts recreate and update the OpenstackMachine spec (the instanceID and providerID) which is immutable. This PR disables the attempt to recreate (consistent behaviour with other broken states example)

Fixes #1787

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: strudelPi / name: Jan Mraz (e939503)

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	e939503
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/659e6f46551c80000834c79c
😎 Deploy Preview	https://deploy-preview-1807--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Welcome @strudelPi!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @strudelPi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/ok-to-test

[k8s-ci-robot]

@MaysaMacedo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/ok-to-test

[strudelPi]

I just realized that the same use case of vanishing machines is a trouble when a delete on that machine is attempted. I think the finalizer makes it so that the delete hangs forever. Will need to check on that further.

[mdbooth]

I just realized that the same use case of vanishing machines is a trouble when a delete on that machine is attempted. I think the finalizer makes it so that the delete hangs forever. Will need to check on that further.

This should be ok. In general we treat 404 as success on delete:

cluster-api-provider-openstack/pkg/cloud/services/compute/instance.go

Lines 766 to 769 in 5f306c3

	if capoerrors.IsNotFound(err) {
	record.Eventf(eventObject, "SuccessfulDeleteServer", "Server %s with id %s did not exist", instance.Name, instance.ID)
	return nil
	}

[mdbooth]

This is a nasty bug, thanks!

I've approved, but I'd appreciate it if you would make the requested change to call SetFailure() before merging. You'll still need LGTM from somebody.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, strudelPi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/cherry-pick release-0.9

[k8s-infra-cherrypick-robot]

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mdbooth]

Thanks for the update. Lets wait for a second reviewer to leave lgtm.

[dulek]

/lgtm

[EmilienM]

/hold cancel

[k8s-infra-cherrypick-robot]

@mdbooth: new pull request created: #1819

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.