🐛 Fall back to cluster identityRef in absence of machine identityRef

[stephenfin]

What this PR does / why we need it:

The identityRef attribute is marked as optional but without it we have no ability to talk to the cloud. In a future API version, we may wish to make this a required attribute but for now, provide the ability to retrieve credentials from the cluster in the absence of the machine.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #1759

Special notes for your reviewer:

I'm not sure if we can do this. As things stand, this will cause a change in behavior (you can create a Machine without specifying an identityRef) between two different CAPO deployments regardless of API version selected. It might be better to instead explode early (rather than exploding later) and make this field required in API v1alpha8/v1beta1? Open to input here.

(We discussed the above 👆 on Slack and agreed it wasn't an issue)

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	08a1ecd
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/656dc7266fd1c30008215b24
😎 Deploy Preview	https://deploy-preview-1768--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-test

[jichenjc]

I'm not sure if we can do this. As things stand, this will cause a change in behavior (you can create a Machine without specifying an identityRef) between two different CAPO deployments regardless of API version selected. It might be better to instead explode early (rather than exploding later) and make this field required in API v1alpha8/v1beta1? Open to input here

maybe we can talk at original issue, but I think it's better to work as you proposed (fall back to cluster identityRef)
but this won't need a API change to v1alpha8/v1beta1 as it's optional anyway per your proposal above?

[stephenfin]

I'm not sure if we can do this. As things stand, this will cause a change in behavior (you can create a Machine without specifying an identityRef) between two different CAPO deployments regardless of API version selected. It might be better to instead explode early (rather than exploding later) and make this field required in API v1alpha8/v1beta1? Open to input here

maybe we can talk at original issue, but I think it's better to work as you proposed (fall back to cluster identityRef) but this won't need a API change to v1alpha8/v1beta1 as it's optional anyway per your proposal above?

Yeah, I discussed this with @mdbooth on Slack and it sounds like an non-issue. We can probably proceed with this as-is, assuming there are no other issues?

EDIT: I updated the PR summary to reflect this.

[dulek]

Makes sense to me!

[mdbooth]

This is an easy win. Lets get it out of the way.

/approve
/lgtm
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/cherry-pick release-0.9

[k8s-infra-cherrypick-robot]

@mdbooth: new pull request created: #1926

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mdbooth]

/cherry-pick release-0.9

[k8s-infra-cherrypick-robot]

@mdbooth: new pull request created: #2093

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.