🐛 Only delete all ports when deleting cluster network #1680
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@lentzi90 Assuming this merges I'd like to backport it to v0.8. What do you think? |
Makes sense to me! |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
|
@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@mdbooth: new pull request created: #1683 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Change #1260 was added as a stop-gap to clean up after errors in the machine controller which left dangling ports in the cluster network. These dangling ports prevent the deletion of the network. It works by deleting all ports in the cluster network.
This makes sense when the cluster network is about to be deleted, but not when the cluster network is a BYO network with non-CAPO managed resources in it. We should not call this method on a BYO network.
Fixes #1679
/hold