Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Port Leaks #1648

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Commits on Aug 25, 2023

  1. Fix Port Leaks

    When an instance fails to come up, there's a bug where the port doesn't
    get cleaned up, and eventually you will exhaust your quota. The code
    does attempt to garbage collect, but I suspect at some point in the past
    ports were suffixed with an index, but the garbage collection code
    wasn't made aware of this, so lists nothing. Replace the APi "filtering"
    that doesn't work with a better algorithm that uses the instance
    creation code to generate the expected ports, then generate the names
    and delete if the port exists. Also protected with some nice unit tests.
    spjmurray committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b77e660 View commit details
    Browse the repository at this point in the history