Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Remove ensure kind binary script from repository #1036

Merged
merged 2 commits into from
Nov 9, 2021
Merged

✨ Remove ensure kind binary script from repository #1036

merged 2 commits into from
Nov 9, 2021

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Nov 1, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1035

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese [email protected], Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2021
@netlify
Copy link

netlify bot commented Nov 1, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: ea5862a

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6180f03d74030500083c2c98

😎 Browse the preview: https://deploy-preview-1036--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2021
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/bump-kind-v0.11.1 branch from 189305c to ef13a3e Compare November 1, 2021 18:10
@tobiasgiese tobiasgiese changed the title ✨ Bump kind to v0.11.1 to test with Kubernetes v1.21.1 ✨ Bump kind to v0.11.1 to deploy CAPI to Kubernetes v1.21.1 Nov 1, 2021
@tobiasgiese
Copy link
Member Author

Do we even need the ensure-kind.sh script if we download the kind binary via make -C hack/tools bin/kind?
I think my PR is kind of obsolete, isn't it?

@tobiasgiese tobiasgiese force-pushed the tobiasgiese/bump-kind-v0.11.1 branch from ef13a3e to b0aee13 Compare November 1, 2021 18:28
@tobiasgiese tobiasgiese changed the title ✨ Bump kind to v0.11.1 to deploy CAPI to Kubernetes v1.21.1 [WIP] ✨ Bump kind to v0.11.1 to deploy CAPI to Kubernetes v1.21.1 Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2021
@tobiasgiese tobiasgiese changed the title [WIP] ✨ Bump kind to v0.11.1 to deploy CAPI to Kubernetes v1.21.1 [WIP] ✨ Remove ensure kind binary script from repository Nov 2, 2021
@tobiasgiese
Copy link
Member Author

tobiasgiese commented Nov 2, 2021 •
edited
Loading

If the pull-cluster-api-provider-openstack-e2e-test is green we don't need this binary anymore 🙂

@tobiasgiese tobiasgiese changed the title [WIP] ✨ Remove ensure kind binary script from repository ✨ Remove ensure kind binary script from repository Nov 2, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2021
@tobiasgiese
Copy link
Member Author

If the pull-cluster-api-provider-openstack-e2e-test is green we don't need this binary anymore slightly_smiling_face

🟢

@jichenjc
Copy link
Contributor

jichenjc commented Nov 4, 2021

/approve

seems the test doesn't need kind

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@hidekazuna
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@jichenjc
Copy link
Contributor

jichenjc commented Nov 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit b6695f2 into kubernetes-sigs:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

Assignees

@hidekazuna hidekazuna

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ensure kind binary script from repository
4 participants
@tobiasgiese @jichenjc @k8s-ci-robot @hidekazuna