Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Add unit tests for getOrCreatePort func #1020

Merged
merged 1 commit into from
Oct 13, 2021
Merged

🏃 Add unit tests for getOrCreatePort func #1020

merged 1 commit into from
Oct 13, 2021

Conversation

macaptain
Copy link
Contributor

@macaptain macaptain commented Oct 6, 2021 •
edited
Loading

The getOrCreatePort func is quite complicated, taking many arguments and options and with conditional calls to OpenStack. This change adds unit tests for the function, which should make it clearer what OpenStack API calls are made under which conditions, and shows off all the supported features.

What this PR does / why we need it: Improves unit test coverage in the networking package, helps avoid future regressions in the ports logic

Which issue(s) this PR fixes:
Helps with #843

TODOs:

  • squashed commits
  • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @macaptain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2021
@netlify
Copy link

netlify bot commented Oct 6, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 43df21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6165395e54ddaa000756f44d

😎 Browse the preview: https://deploy-preview-1020--kubernetes-sigs-cluster-api-openstack.netlify.app

@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2021
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@macaptain
Add unit tests for getOrCreatePort func
43df21f 
The getOrCreatePort func is quite complicated, taking many arguments and
options and with conditional calls to OpenStack. This change adds unit
tests for the function, which should make it clearer what OpenStack API
calls are made under which conditions, and shows off all the supported
features.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@iamemilio
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@iamemilio
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@jichenjc
Copy link
Contributor

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, macaptain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8b17f0e into kubernetes-sigs:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio iamemilio left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@prankul88 prankul88 Awaiting requested review from prankul88

Assignees

@iamemilio iamemilio

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macaptain @k8s-ci-robot @chrischdi @jichenjc @iamemilio