-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Move deletePorts back to compute package #1002
🏃 Move deletePorts back to compute package #1002
Conversation
Following up on kubernetes-sigs#950, this moves the deletePorts function back to the compute package where it can be made a private function.
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 12f240f 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6149ff61ef31c70008e45eed 😎 Browse the preview: https://deploy-preview-1002--kubernetes-sigs-cluster-api-openstack.netlify.app |
Hi @macaptain. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, macaptain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following up on @mdbooth's review of #950, this moves the
deletePorts
function from the networking package back to the compute package where it can be made a private function.What this PR does / why we need it: fixes a nit from a review of #950
Special notes for your reviewer:
TODOs:
/hold