worker node do not have roles

[gyliu513]

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

After my cluster was provisioned, I found that the worker node role is none, but master node do have a role named as master, so I think that we should also add a role for worker node as well.

root@liugya-master-cpr5j:~# kubectl get nodes
NAME                  STATUS   ROLES    AGE     VERSION
liugya-master-cpr5j   Ready    master   3h50m   v1.14.0
liugya-node-ngw58     Ready    <none>   3h47m   v1.14.0

/cc @jichenjc @chrigl

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api version:
• Minikube/KIND version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[jichenjc]

I found same situation, will something like 'worker' enough @gyliu513 ?

[gyliu513]

@jichenjc Yes, I think we can set it as worker first.

[jichenjc]

I am working on this, seems

kubectl label node minikube node-role.kubernetes.io/worker=

works, however, the issue is we need create master first then apply the nodes after that
then we are done..so need some place to add this logic,maybe in cluster-api??

kubectl get nodes
NAME STATUS ROLES AGE VERSION
minikube Ready master 33h v1.12.7
root@kvm-017751:/go/src/sigs.k8s.io/cluster-api-provider-openstack/cmd/clusterctl/examples/openstack/provider-component/user-data/ubuntu# kubectl label node minikube node-role.kubernetes.io/worker=
node/minikube labeled
root@kvm-017751:/go/src/sigs.k8s.io/cluster-api-provider-openstack/cmd/clusterctl/examples/openstack/provider-component/user-data/ubuntu# kubectl get nodes
NAME STATUS ROLES AGE VERSION
minikube Ready master,worker 33h v1.12.7

[jichenjc]

/assign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.